Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chocolate bonbons #4627

Closed
wants to merge 5 commits into from
Closed

Chocolate bonbons #4627

wants to merge 5 commits into from

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Dec 12, 2020 •
edited by teolemon
Loading

What

There was a missing ecoscore here.

It fits however: https://www.agribalyse.fr/app/aliments/31091#Bonbon_/_bouchée_au_chocolat_fourrage_gaufrettes_/_biscuit

Which seems a pretty large category.

Part of

@aleene
Added agribalyse to choclate bonbons
f7a558c 
Bonbon / bouchée au chocolat fourrage gaufrettes / biscuit

31091
@aleene
Update categories.txt
16e44d8
@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products labels Dec 12, 2020
stephanegigandet
stephanegigandet requested changes Dec 14, 2020
View reviewed changes
taxonomies/categories.txt Outdated
@@ -27286,29 +27286,11 @@ nl:Pralines, chocolades snoepjes
pt:Bombons
ru:Конфеты
wikidata:en:Q3272827
agribalyse_food_code:en:31091
ciqual_food_code:en:31091
ciqual_food_name:en:Chocolate confectionery, filled with wafer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this CIQUAL category is for chocolate confectionery with a wafer filling, it's not any kind of candy, it does not work here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more this one: https://www.agribalyse.fr/app/aliments/31063#Bouchée_chocolat_fourrage_fruits_à_coques_et/ou_praliné

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact my mistake, Github is not showing the lines above (only 3), I didn't realize it was for chocolate bonbons.

so it's a good category. Make it a proxy maybe.

Suggested change
ciqual_food_name:en:Chocolate confectionery, filled with wafer
ciqual_proxy_food_name:en:Chocolate confectionery, filled with wafer

stephanegigandet
stephanegigandet reviewed Dec 16, 2020
View reviewed changes
taxonomies/categories.txt Outdated
@@ -27286,29 +27286,11 @@ nl:Pralines, chocolades snoepjes
pt:Bombons
ru:Конфеты
wikidata:en:Q3272827
agribalyse_food_code:en:31091
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
agribalyse_food_code:en:31091
agribalyse_proxy_food_code:en:31091

stephanegigandet
stephanegigandet reviewed Dec 16, 2020
View reviewed changes
taxonomies/categories.txt Outdated
@@ -27286,29 +27286,11 @@ nl:Pralines, chocolades snoepjes
pt:Bombons
ru:Конфеты
wikidata:en:Q3272827
agribalyse_food_code:en:31091
ciqual_food_code:en:31091
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ciqual_food_code:en:31091
ciqual_proxy_food_code:en:31091

@teolemon teolemon added the 💥 Merge Conflicts 💥 Merge Conflicts label Jan 29, 2021
This was referenced Aug 21, 2021
Open
Open
@aleene aleene removed the 💥 Merge Conflicts 💥 Merge Conflicts label Nov 11, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aleene aleene self-assigned this Nov 11, 2021
@aleene aleene closed this Dec 2, 2021
@teolemon teolemon added the CIQUAL https://www.anses.fr/en/content/anses-ciqual-food-composition-table label Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet requested changes

Assignees

@aleene aleene

Labels
CIQUAL https://www.anses.fr/en/content/anses-ciqual-food-composition-table 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleene @stephanegigandet @teolemon